FLUID-2223: Clean up the contract for UI Options and UI Enhancer.

Metadata

Source
FLUID-2223
Type
Bug
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
Colin Clark
Reporter
Michelle D'Souza
Created
2009-02-11T15:20:41.000-0500
Updated
2009-03-25T10:03:27.000-0400
Versions
N/A
Fixed Versions
  1. 1.0
Component
  1. FSS
  2. UIEnhancer
  3. UI Options

Description

The contract for creating a UI Options component needs to be refined. Integrators using FSS for their own styling need to communicate this to UI Options.

More events need to be created and fired including onCancel.

Comments

  • Justin Obara commented 2009-03-12T13:28:13.000-0400

    Bug Parade 1.0 release

  • Michelle D'Souza commented 2009-03-23T16:47:35.000-0400

    A lot of changes in the API have happened from the start of this issue. They include:

    UI Enhancer was renamed from Skin and became a Fluid Infusion component.
    UI Enhancer has state

    • defaultSiteSettings which is the integrator's defaults
    • model which is the current settings
      fssMap in UI Enhancer was renamed to classnameMap

    UI Options:

    The properties renderModel, originalModel and savedModel were removed from the 'that'.
    The events onReset, onCancel and afterRender were added and fired appropriately.
    Two subcomponents were added: textMinSize and lineSpacing.
    The selectors were changed to use the flc namespace.
    The 'preview' selector was removed.
    'savedSelections' was removed from the options and is now pulled out of UIEnhancer.
    'renderModel' was broken up into something more understandable: 'strings' and 'controlValues'

  • Michelle D'Souza commented 2009-03-23T16:48:32.000-0400

    It would be good if Colin could code review this since he code reviewed and made suggestions several times during the implementation.

  • Justin Obara commented 2009-03-25T10:03:27.000-0400

    Verified fix using:

    FF2, FF3, Opera 9.6, Safari 3.2 (Mac OS 10.5)
    FF2, FF3, IE6, Opera 9.6 (Win XP)
    FF3, IE7 (Win Vista)