FLUID-3487: Promote fluid.deadMansBlur() to framework

Metadata

Source
FLUID-3487
Type
Improvement
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
Antranig Basman
Reporter
Anastasia Cheetham
Created
2010-01-28T15:26:45.000-0500
Updated
2012-03-27T02:50:53.687-0400
Versions
  1. 1.1.2
  2. 1.2
Fixed Versions
  1. 1.3
Component
  1. Framework
  2. Inline Edit

Description

The InlineEdit component includes a function called fluid.deadMansBlur() that has proven helpful in several contexts outside of InlineEdit. It would be nice if it was promoted to a framework function so that users could use it without having to include InlineEdit.js in their application.

Comments

  • Justin Obara commented 2010-10-04T15:23:46.785-0400

    "Bug Parade Infusion 1.3"

  • Antranig Basman commented 2010-11-12T19:29:40.413-0500

    Fixed at revision 10236

  • Anastasia Cheetham commented 2010-11-19T13:06:19.132-0500

    There are no tests for fluid.deadMansBlur() (nor for anything else in FluidDocument.js). I know we might be restructuring things again, but it would be really great if we took this opportunity to increase our test coverage.

  • Antranig Basman commented 2010-12-10T15:32:49.723-0500

    Implemented with test cases at revision 10382 - review required

  • Antranig Basman commented 2010-12-14T02:14:50.320-0500

    Test cases and implementation were found to be failing under IE. Reopened as release blocker

  • Antranig Basman commented 2010-12-14T02:18:04.477-0500

    Fixes with test case and implementation verified functioning under both FF and IE8.

  • y z commented 2010-12-14T13:22:32.912-0500

    Focusin doesn't seem to work on exclusions that are dynamically rendered on the page in IE.

  • Jonathan Hung commented 2010-12-14T13:29:35.159-0500

    FluidView-test.html test runs fine in IE7 WinXP. Manual dropdown.html test can not load in IE7 WinXP. ("Operation aborted" when loading page).

    FluidView-test.html test runs fine in IE8 Win7. Manual dropdown.html test runs fine in IE8 Win7.

  • Antranig Basman commented 2010-12-14T14:45:08.535-0500

    Revised version of the patch "FLUID-3487-b" that may succeed in resolving some issues on IE.

  • Antranig Basman commented 2010-12-14T15:10:39.569-0500

    Attached version "c" of patch which works under IE6, as well as test cases. Uses "document.ready" for initialising component

  • Antranig Basman commented 2010-12-14T15:57:31.759-0500

    Version "d" of the patch corrects for the linting that occurred in trunk since it was generated. This patch has been relinted.

  • Antranig Basman commented 2010-12-14T16:51:30.984-0500

    Version "i" of patch using focusin which is verified under FF, IE6, and IE8 - please test on IE7 also

  • Colin Clark commented 2010-12-15T10:26:37.253-0500

    I reviewed, tested, and committed Antranig's -i patch for this issue, and it looks good. +1 for inclusion in Infusion 1.3.

  • Antranig Basman commented 2010-12-16T02:42:29.127-0500

    Unfortunately the implementation supplied for the "i" patch and accepted for the 1.3 release is not sufficient for some use cases in IE8, especially where those involve the use of the jquery.keyboard-a11y "selectable" plugin within the domain managed by Dead Man's Blur. More work will be needed on an even more capable implementation for the 1.4 release

  • Antranig Basman commented 2010-12-16T02:44:58.429-0500

    New implementation involving "proleptic blur" and use of synthetic "fluid-focus" and "fluid-blur" events in keyboard-a11y is now capable of dealing with interactions between fluid.selectable and fluid.deadMansBlur on IE8. This patch "FLUID-3487-j" is non-cumulative and applies to the state of trunk after patch version "i" was applied.

  • Justin Obara commented 2011-01-17T11:52:23.170-0500

    fluid.deadMansBlur is now in FluidView.js. Any issues related to it, should be filed under new jiras

  • Antranig Basman commented 2012-03-27T02:50:53.685-0400

    See http://old.nabble.com/CSPACE-3304---dismissing-popup-areas-on-IE8-ts30470733.html for discussion on CSPACE-3304, the corresponding issue which motivated most of this development.