FLUID-3899: "primeCacheFromResources" fails with exception if IoC system is included

Metadata

Source
FLUID-3899
Type
Bug
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
Justin Obara
Reporter
y z
Created
2010-12-14T01:08:39.320-0500
Updated
2010-12-15T18:32:41.885-0500
Versions
  1. 1.2.1
Fixed Versions
  1. 1.3
Component
  1. IoC System

Description

When calling expand options without providing the "that" argument (fluid.fetchResources.primeCacheFromResources), fluid.withNewComponent will not fix the thatStack and thus will fail when trying to operate on it.

Comments

  • Antranig Basman commented 2010-12-14T01:19:05.443-0500

    Fix with test cases for this issue. "fluid.withNewComponent" now no longer appears as if it expects it can be called without a "that" instance, and all clients will now conform.

  • Antranig Basman commented 2010-12-14T01:21:13.666-0500

    "Bug Parade Infusion 1.3"

  • Antranig Basman commented 2010-12-15T15:15:54.276-0500

    Attached version "b" of patch that has been corrected for linting in trunk

  • Colin Clark commented 2010-12-15T18:16:12.509-0500

    Here's a version of the patch that applies cleanly against trunk without reverting any linted parts.

  • Colin Clark commented 2010-12-15T18:31:15.190-0500

    I've reviewed Antranig's fix for this issue, run all the appropriate unit tests (including those for Uploader and Reorderer), tested everything that depends on IoC, and everything works. +1 for this last-minute inclusion in 1.3.

  • Colin Clark commented 2010-12-15T18:32:41.878-0500

    This issue has been reviewed, tested, and committed. We're good to go.