FLUID-4504: Focus styling not visible for the "Save and Apply", "Reset and Apply" and "Cancel" buttons in the "... on black" contrast themes

Metadata

Source
FLUID-4504
Type
Bug
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
Michelle D'Souza
Reporter
Justin Obara
Created
2011-10-04T14:28:28.722-0400
Updated
2011-10-07T14:02:26.718-0400
Versions
  1. 1.4
Fixed Versions
  1. 1.4
Component
  1. UI Options

Description

Steps to reproduce

1) Open the "Full No Preview" version of UI Options from the UIO Demo
http://build.fluidproject.org/infusion/demos/uiOptions/html/uiOptions.html

2) Change the contrast theme to "White on Black" or "Yellow on Black" and save

3) Using the keyboard, place focus on the "Save and Apply", "Reset and Apply" or "Cancel" button. Notice that there is no visible focus styling

Environments

FF 6 (Mac OS 10.6)

Comments

  • Justin Obara commented 2011-10-05T13:50:12.686-0400

    Merged Heidi's pull request https://github.com/fluid-project/infusion/pull/183 into the project repo at 1cc4ed0b9200e1af2921ebe1415d48bb9eb91b04

  • Justin Obara commented 2011-10-06T12:01:18.046-0400

    This actually turns out to be a bit larger than originally believed. In discussing this with James, Michelle, and Anastasia we decided that focus should be always added by the contrast themes. This means that they shouldn't rely on the fl-focus scoping.

  • Anastasia Cheetham commented 2011-10-06T15:44:31.096-0400

    The original fix which added the blue outline to the dialog's controls does NOT work for IE6 and IE7 on Win XP.

  • Justin Obara commented 2011-10-07T13:23:33.435-0400

    In discussing this more on list we have now decided that the proper way to address this, at this point, is to just simply add the fl-focus class into the demo.

    This is discussed in more detail on an e-mail thread from the fluid-work list.
    http://lists.idrc.ocad.ca/pipermail/fluid-work/2011-October/008186.html

  • Michelle D'Souza commented 2011-10-07T13:54:07.013-0400

    I've opened FLUID-4512 to address Anastasia's comment above.

  • Justin Obara commented 2011-10-07T14:02:26.695-0400

    Pushed Michelle's pull request https://github.com/fluid-project/infusion/pull/185 into the project repo 1a4334608388675a792abf76175f429b230049ba