Metadata
- Source
- VP-66
- Type
- Bug
- Priority
- Blocker
- Status
- Closed
- Resolution
- Fixed
- Assignee
- Michelle D'Souza
- Reporter
- Colin Clark
- Created
2012-09-27T13:18:42.679-0400 - Updated
2013-03-01T09:12:05.526-0500 - Versions
- N/A
- Fixed Versions
- N/A
- Component
-
- captions
Description
We have added support for Data URLs in the <track> element support for Captionator. At the moment, it's a fairly simple implementation that doesn't do the following things:
1. Handle all the variations of data URLs
2. Decode Base64-encoded data URLs
3. Check that the data in the data URL is actually a valid WebVTT document
Here's an example of a slightly more robust DataURL parser, which we should steal from (I hear the author's an ok guy):
https://github.com/colinbdclark/Flocking/blob/master/flocking/flocking-audiofile.js#L104-119
https://github.com/colinbdclark/Flocking/blob/master/tests/flocking/js/audiofile-tests.js#L24-52
Comments
-
Michelle D'Souza commented
2012-12-14T10:49:49.822-0500 Fixed at commit: 02a19dba710a7897e80dc0c00de6ea03cde2a865